Issue 12324012: Try to not use incomplete Dart types in HType.

Issue 12324012: Try to not use incomplete Dart types in HType. (Closed)

Created:
7 years, 10 months ago by ngeoffray

Modified:
7 years, 10 months ago

Reviewers:
Johnni Winther, karlklose

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Try to not use incomplete Dart types in HType. Committed: https://code.google.com/p/dart/source/detail?r=18760

Patch Set 3 : #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/types.dart	View		1 chunk	+1 line, -1 line	2 comments	Download
M	tests/lib/lib.status	View	1 2	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/12324012/diff/5001/sdk/lib/_internal/compiler/implementation/ssa/types.dart File sdk/lib/_internal/compiler/implementation/ssa/types.dart (right): https://codereview.chromium.org/12324012/diff/5001/sdk/lib/_internal/compiler/implementation/ssa/types.dart#newcode702 sdk/lib/_internal/compiler/implementation/ssa/types.dart:702: return backend.jsArrayClass.computeType(compiler).asRaw(); Use 'return backend.jsArrayClass.rawType'?

7 years, 10 months ago (2013-02-20 15:00:48 UTC) #2

ngeoffray

Thanks Karl. https://codereview.chromium.org/12324012/diff/5001/sdk/lib/_internal/compiler/implementation/ssa/types.dart File sdk/lib/_internal/compiler/implementation/ssa/types.dart (right): https://codereview.chromium.org/12324012/diff/5001/sdk/lib/_internal/compiler/implementation/ssa/types.dart#newcode702 sdk/lib/_internal/compiler/implementation/ssa/types.dart:702: return backend.jsArrayClass.computeType(compiler).asRaw(); On 2013/02/20 15:00:48, karlklose wrote: ...

7 years, 10 months ago (2013-02-20 15:12:50 UTC) #3

ngeoffray

7 years, 10 months ago (2013-02-20 15:13:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r18760 (presubmit successful).

Expand Messages | Collapse Messages