Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 12324004: Add test for whether a completer or stream controller has been closed. (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add test for whether a completer or stream controller has been closed. BUG=http://dartbug.com/8638 Committed: https://code.google.com/p/dart/source/detail?r=19211

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments. It's isCompleted. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M sdk/lib/async/future.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/async/future_impl.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/lib/async/future_test.dart View 4 chunks +10 lines, -0 lines 0 comments Download
M tests/lib/async/stream_controller_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
Naming is perhaps inconsistent. It uses "completed" but "isClosed". The problem is that the correct ...
7 years, 10 months ago (2013-02-20 13:24:12 UTC) #1
floitsch
I would like us to use "completed" everywhere. No "complete". "It is completed" does not ...
7 years, 10 months ago (2013-02-26 13:57:32 UTC) #2
floitsch
and LGTM.
7 years, 10 months ago (2013-02-26 14:02:38 UTC) #3
Lasse Reichstein Nielsen
7 years, 9 months ago (2013-02-28 11:37:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698