Add notification of analyzed files

Add notification of analyzed files

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/2ffa8de794a2bfbfccf1e35a9a64a1a3029bd0c8

[Brian Wilkerson, 2015-07-13 21:36:52]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-07-13 21:51:13]

I also have a clarifying question which I'll ask in person.

https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:771: if
(generalAnalysisServices
Consider putting this before the call to sendStatusNotifcation(null) so that
when the client receives a status message indicating that analysis is done,
there will be no further notifications pending.  This should make integration
testing easier (should we choose to integration test this feature :)).

https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/test/an...
File pkg/analysis_server/test/analysis/test_all.dart (right):

https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/test/an...
pkg/analysis_server/test/analysis/test_all.dart:11: import
'notification_analyzedFiles_test.dart'
Did you forget to add this file?  I don't see it.

[Paul Berry, 2015-07-13 22:03:15]

On 2015/07/13 21:51:13, Paul Berry wrote:
> I also have a clarifying question which I'll ask in person.
> 
>
https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/lib/src...
> File pkg/analysis_server/lib/src/analysis_server.dart (right):
> 
>
https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/lib/src...
> pkg/analysis_server/lib/src/analysis_server.dart:771: if
> (generalAnalysisServices
> Consider putting this before the call to sendStatusNotifcation(null) so that
> when the client receives a status message indicating that analysis is done,
> there will be no further notifications pending.  This should make integration
> testing easier (should we choose to integration test this feature :)).
> 
>
https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/test/an...
> File pkg/analysis_server/test/analysis/test_all.dart (right):
> 
>
https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/test/an...
> pkg/analysis_server/test/analysis/test_all.dart:11: import
> 'notification_analyzedFiles_test.dart'
> Did you forget to add this file?  I don't see it.

As discussed, lgtm with the missing file added.  I'll do follow-up work.

[Brian Wilkerson, 2015-07-13 22:05:03]

https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:771: if
(generalAnalysisServices
Done

https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/test/an...
File pkg/analysis_server/test/analysis/test_all.dart (right):

https://codereview.chromium.org/1232393005/diff/1/pkg/analysis_server/test/an...
pkg/analysis_server/test/analysis/test_all.dart:11: import
'notification_analyzedFiles_test.dart'
Yes, done.

[Brian Wilkerson, 2015-07-13 22:07:41]

Committed patchset #1 (id:1) manually as
2ffa8de794a2bfbfccf1e35a9a64a1a3029bd0c8 (presubmit successful).