Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1232243004: Ensure that there is a stack trace when reporting a server error (Closed)

Created:
5 years, 5 months ago by Brian Wilkerson
Modified:
5 years, 5 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure that there is a stack trace when reporting a server error R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/1dfef4bb0c9f9016fdbdb3d9ecee1d66f80c64e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
I couldn't find any place in the code where we're failing to pass in a ...
5 years, 5 months ago (2015-07-16 16:00:59 UTC) #2
Paul Berry
lgtm
5 years, 5 months ago (2015-07-16 17:32:41 UTC) #3
Brian Wilkerson
5 years, 5 months ago (2015-07-16 17:36:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1dfef4bb0c9f9016fdbdb3d9ecee1d66f80c64e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698