Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 12321154: Add Dartdoc testing to pub bots. (Closed)

Created:
7 years, 10 months ago by Andrei Mouravski
Modified:
7 years, 9 months ago
Reviewers:
ricow1, Bob Nystrom
CC:
reviews_dartlang.org, nweiz, Jacob
Visibility:
Public.

Description

Add Dartdoc testing to pub bots. Committed: https://code.google.com/p/dart/source/detail?r=19417

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
A sdk/lib/_internal/dartdoc/dartdoc.status View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M tools/bots/pub.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/test.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Andrei Mouravski
I propose adding the dartdoc + markdown tests to the pub bots.
7 years, 10 months ago (2013-02-27 01:20:32 UTC) #1
Bob Nystrom
LGTM. Can you add someone from the testing team too? Maybe ricow?
7 years, 9 months ago (2013-02-27 18:53:59 UTC) #2
Andrei Mouravski
On 2013/02/27 18:53:59, Bob Nystrom wrote: > LGTM. Can you add someone from the testing ...
7 years, 9 months ago (2013-02-27 18:57:10 UTC) #3
Andrei Mouravski
Added the wrong ricow before.
7 years, 9 months ago (2013-02-28 14:45:37 UTC) #4
ricow1
https://chromiumcodereview.appspot.com/12321154/diff/4001/sdk/lib/_internal/dartdoc/dartdoc.status File sdk/lib/_internal/dartdoc/dartdoc.status (right): https://chromiumcodereview.appspot.com/12321154/diff/4001/sdk/lib/_internal/dartdoc/dartdoc.status#newcode14 sdk/lib/_internal/dartdoc/dartdoc.status:14: [ $runtime == drt || $runtime == dartium || ...
7 years, 9 months ago (2013-02-28 14:56:19 UTC) #5
Andrei Mouravski
PTAL. https://codereview.chromium.org/12321154/diff/4001/sdk/lib/_internal/dartdoc/dartdoc.status File sdk/lib/_internal/dartdoc/dartdoc.status (right): https://codereview.chromium.org/12321154/diff/4001/sdk/lib/_internal/dartdoc/dartdoc.status#newcode14 sdk/lib/_internal/dartdoc/dartdoc.status:14: [ $runtime == drt || $runtime == dartium ...
7 years, 9 months ago (2013-02-28 16:23:39 UTC) #6
kevmoo-old
Not a reviewer but: 1) lgtm 2) verified runs on my mac against HEAD 3) ...
7 years, 9 months ago (2013-02-28 22:42:33 UTC) #7
ricow1
LGTM, sorry for delay https://codereview.chromium.org/12321154/diff/12001/sdk/lib/_internal/dartdoc/dartdoc.status File sdk/lib/_internal/dartdoc/dartdoc.status (right): https://codereview.chromium.org/12321154/diff/12001/sdk/lib/_internal/dartdoc/dartdoc.status#newcode13 sdk/lib/_internal/dartdoc/dartdoc.status:13: # Dartdoc only runs on ...
7 years, 9 months ago (2013-03-04 06:42:57 UTC) #8
Andrei Mouravski
7 years, 9 months ago (2013-03-04 19:40:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 manually as r19417 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698