Issue 12321122: Add a nothing descriptor to scheduled_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12321122: Add a nothing descriptor to scheduled_test. (Closed)

Created:
7 years, 10 months ago by nweiz

Modified:
7 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a nothing descriptor to scheduled_test. BUG=8511 Committed: https://code.google.com/p/dart/source/detail?r=19018

Patch Set 2 : Code review change. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -1 line)			Patch
M	pkg/scheduled_test/lib/descriptor.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download
A	pkg/scheduled_test/lib/src/descriptor/nothing.dart	View	1	1 chunk	+60 lines, -0 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/descriptor/utils.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/test/descriptor_test.dart	View		1 chunk	+124 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One comment. Otherwise LGTM. https://codereview.chromium.org/12321122/diff/1/pkg/scheduled_test/lib/src/descriptor/nothing.dart File pkg/scheduled_test/lib/src/descriptor/nothing.dart (right): https://codereview.chromium.org/12321122/diff/1/pkg/scheduled_test/lib/src/descriptor/nothing.dart#newcode29 pkg/scheduled_test/lib/src/descriptor/nothing.dart:29: return new File(fullPath).exists().then((fileExists) { Let's ...

7 years, 10 months ago (2013-02-25 22:59:13 UTC) #2

nweiz

7 years, 10 months ago (2013-02-25 23:27:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19018 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12321122: Add a nothing descriptor to scheduled_test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review change. #

Messages