Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 12321111: Add machine readable markers around code and flow graph output printed for --print-flow-graph and -… (Closed)

Created:
7 years, 10 months ago by Vyacheslav Egorov (Google)
Modified:
7 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add machine readable markers around code and flow graph output printed for --print-flow-graph and --disassemble-optimized. This allows to quickly preparse large IR/code dumps when loading then into the tools instead of parsing them line by line and figuring out where things start and end. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M runtime/vm/compiler.cc View 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
7 years, 10 months ago (2013-02-25 13:05:45 UTC) #1
Florian Schneider
lgtm
7 years, 10 months ago (2013-02-25 13:08:23 UTC) #2
Vyacheslav Egorov (Google)
7 years, 10 months ago (2013-02-25 13:09:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18966 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698