Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 12321020: Use relative symlinks for self links and secondary "packages" dirs. (Closed)

Created:
7 years, 10 months ago by Bob Nystrom
Modified:
7 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use relative symlinks for self links and secondary "packages" dirs. This lets you move a package directory without breaking all of those links. BUG=http://code.google.com/p/dart/issues/detail?id=8342 Committed: https://code.google.com/p/dart/source/detail?r=18785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M utils/pub/entrypoint.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/pub_install_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A utils/tests/pub/install/relative_symlink_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
7 years, 10 months ago (2013-02-20 19:56:21 UTC) #1
nweiz
lgtm
7 years, 10 months ago (2013-02-20 20:37:13 UTC) #2
Bob Nystrom
7 years, 10 months ago (2013-02-20 21:17:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18785 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698