Issue 12321010: Increase size for slow-consumer test (overflows memory on X64).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12321010: Increase size for slow-consumer test (overflows memory on X64). (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 10 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Increase size for slow-consumer test (overflows memory on X64). Address comments from previous commit. Make recursive callbacks from a Stream work correctly. Committed: https://code.google.com/p/dart/source/detail?r=18753

Patch Set 1 #

Total comments: 1

Patch Set 2 : Done #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -13 lines)			Patch
	M	sdk/lib/async/stream_impl.dart	View	1	5 chunks	+24 lines, -11 lines	0 comments	Download
	M	tests/lib/async/slow_consumer_test.dart	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/12321010/diff/1/sdk/lib/async/stream_impl.dart File sdk/lib/async/stream_impl.dart (right): https://codereview.chromium.org/12321010/diff/1/sdk/lib/async/stream_impl.dart#newcode342 sdk/lib/async/stream_impl.dart:342: } Use else.

7 years, 10 months ago (2013-02-20 13:17:32 UTC) #2

Lasse Reichstein Nielsen

7 years, 10 months ago (2013-02-20 13:21:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r18753 (presubmit successful).

Expand Messages | Collapse Messages