Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1232083002: dart2js cps: Emit unlabeled breaks and continues when possible. (Closed)

Created:
5 years, 5 months ago by asgerf
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Emit unlabeled breaks and continues when possible. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/fe2c4c5d97f27c6d58521603e0c4f878367aec96

Patch Set 1 #

Patch Set 2 : Update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -45 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 4 chunks +58 lines, -38 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart View 1 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 5 months ago (2015-07-10 08:49:30 UTC) #2
karlklose
LGTM.
5 years, 5 months ago (2015-07-10 09:22:13 UTC) #3
asgerf
5 years, 5 months ago (2015-07-10 10:25:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fe2c4c5d97f27c6d58521603e0c4f878367aec96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698