Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 12320102: Cleaning up the TableElement API (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 9 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cleaning up the TableElement API Basically just converting to more proper types for a number of the APIs. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19175

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+620 lines, -91 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 8 chunks +203 lines, -26 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 8 chunks +182 lines, -23 lines 0 comments Download
M tests/html/table_test.dart View 1 chunk +29 lines, -11 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/dom/src/WrappedList.dart View 1 chunk +127 lines, -0 lines 2 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
D tools/dom/templates/html/dart2js/impl_HTMLTableElement.darttemplate View 1 chunk +0 lines, -21 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
A tools/dom/templates/html/impl/impl_HTMLTableElement.darttemplate View 1 chunk +42 lines, -0 lines 1 comment Download
A + tools/dom/templates/html/impl/impl_HTMLTableRowElement.darttemplate View 1 chunk +12 lines, -5 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_HTMLTableSectionElement.darttemplate View 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 10 months ago (2013-02-25 22:11:28 UTC) #1
sra1
lgtm if you can fix the wrapper problem, at least for iterators. https://codereview.chromium.org/12320102/diff/5002/tools/dom/src/WrappedList.dart File tools/dom/src/WrappedList.dart ...
7 years, 10 months ago (2013-02-27 03:01:10 UTC) #2
blois
7 years, 9 months ago (2013-02-27 22:18:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19175 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698