Issue 12320088: dart:io: Prevent initial WRITE event on RawSecureSocket when writeEventsEnabled is set to false.

Issue 12320088: dart:io: Prevent initial WRITE event on RawSecureSocket when writeEventsEnabled is set to false. (Closed)

Created:
7 years, 10 months ago by Bill Hesse

Modified:
7 years, 10 months ago

Reviewers:
Søren Gjesse, Anders Johnsen

CC:
reviews_dartlang.org, Søren Gjesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io: Prevent initial WRITE event on RawSecureSocket when writeEventsEnabled is set to false. BUG=dartbug.com/8736 TEST=standalone/io/raw_secure_server_socket_test Committed: https://code.google.com/p/dart/source/detail?r=18967

Patch Set 1 #

Total comments: 4

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sdk/lib/io/secure_socket.dart	View		2 chunks	+2 lines, -0 lines	4 comments	Download
	M	tests/standalone/standalone.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM with comments https://codereview.chromium.org/12320088/diff/1/sdk/lib/io/secure_socket.dart File sdk/lib/io/secure_socket.dart (right): https://codereview.chromium.org/12320088/diff/1/sdk/lib/io/secure_socket.dart#newcode389 sdk/lib/io/secure_socket.dart:389: _controller.hasSubscribers && What about paused? https://codereview.chromium.org/12320088/diff/1/sdk/lib/io/secure_socket.dart#newcode493 ...

7 years, 10 months ago (2013-02-25 07:20:44 UTC) #2

Bill Hesse

https://codereview.chromium.org/12320088/diff/1/sdk/lib/io/secure_socket.dart File sdk/lib/io/secure_socket.dart (right): https://codereview.chromium.org/12320088/diff/1/sdk/lib/io/secure_socket.dart#newcode389 sdk/lib/io/secure_socket.dart:389: _controller.hasSubscribers && On 2013/02/25 07:20:44, Søren Gjesse wrote: > ...

7 years, 10 months ago (2013-02-25 07:32:36 UTC) #3

Bill Hesse

Committed patchset #1 manually as r18967 (presubmit successful).

7 years, 10 months ago (2013-02-25 14:41:27 UTC) #4

Søren Gjesse

7 years, 10 months ago (2013-02-25 14:50:53 UTC) #5

Message was sent while issue was closed.

lgtm

Forgot to send this draft comment...

https://codereview.chromium.org/12320088/diff/1/sdk/lib/io/secure_socket.dart
File sdk/lib/io/secure_socket.dart (right):

https://codereview.chromium.org/12320088/diff/1/sdk/lib/io/secure_socket.dart...
sdk/lib/io/secure_socket.dart:389: _controller.hasSubscribers &&
On 2013/02/25 07:32:36, Bill Hesse wrote:
> On 2013/02/25 07:20:44, Søren Gjesse wrote:
> > What about paused?
> 
> It should be legal to enqueue a WRITE event if they are enabled while the
> subscription is paused.  The main thing is to stop events being queued before
> the first .listen.
> 
> Since we only send an initial WRITE event on a .listen call when they are
> enabled, not on a pauseChange, we cannot handle the case that a WRITE event
from
> the base socket comes during a pause, unless we enqueue it at the time it
> arrives.

I agree that it is not an error to send WRITE events when paused. However I
still think we should avoid doing that so that we handle pause/resume and only
send events when not paused.

When unpausing shouldn't just send a WRITE event if there is room in the
plaintext write buffer?

Expand Messages | Collapse Messages