Issue 12320023: Disabled context variables in local variable list in the debugger

Issue 12320023: Disabled context variables in local variable list in the debugger (Closed)

Created:
7 years, 10 months ago by Tom Ball

Modified:
7 years, 10 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disabled context variables in local variable list in the debugger, so developers can still use it while issue 8593 is being fixed. Committed: https://code.google.com/p/dart/source/detail?r=19020

Patch Set 2 : Return <unknown> for context variables now. #

Total comments: 3

Patch Set 5 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+322 lines, -310 lines)			Patch
	M	runtime/vm/debugger.cc	View	1 2 3 4	2 chunks	+5 lines, -1 line	0 comments	Download
	M	runtime/vm/debugger_api_impl_test.cc	View	1 2 3 4	1 chunk	+317 lines, -309 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://codereview.chromium.org/12320023/diff/3/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/12320023/diff/3/runtime/vm/debugger.cc#newcode520 runtime/vm/debugger.cc:520: *value = String::New("<unknown>"); Symbol::New("<unknown>") https://codereview.chromium.org/12320023/diff/3/runtime/vm/debugger.cc#newcode520 runtime/vm/debugger.cc:520: *value = String::New("<unknown>"); ...

7 years, 10 months ago (2013-02-21 01:26:12 UTC) #3

Tom Ball

7 years, 10 months ago (2013-02-21 17:32:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r19020.

Expand Messages | Collapse Messages