Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 12319148: dart:io | Change a remaining use of File.name to File.path, in samples. (Closed)

Created:
7 years, 9 months ago by Bill Hesse
Modified:
7 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Change a remaining use of File.name to File.path, in samples. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19150

Patch Set 1 #

Patch Set 2 : Fix another dartc bug. #

Patch Set 3 : Fix a type error. #

Patch Set 4 : Soeren beat me to it, reverting fix. #

Patch Set 5 : Oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M runtime/bin/file_patch.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M samples/build_dart/build.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 9 months ago (2013-02-27 15:59:40 UTC) #1
Søren Gjesse
lgtm, thanks
7 years, 9 months ago (2013-02-27 16:00:08 UTC) #2
Bill Hesse
7 years, 9 months ago (2013-02-27 16:15:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r19150 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698