Issue 12319067: Handle legacy epoll event on Linux.

Issue 12319067: Handle legacy epoll event on Linux. (Closed)

Created:
7 years, 10 months ago by Anders Johnsen

Modified:
7 years, 6 months ago

Reviewers:
Søren Gjesse, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle legacy epoll event on Linux. This should fix flaky tests on older versions of Linux (including those running buildbot). Also re-enable test on linux. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18873

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add assert #

Total comments: 6

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	runtime/bin/eventhandler_linux.cc	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
	M	tests/standalone/standalone.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM! https://codereview.chromium.org/12319067/diff/1/runtime/bin/eventhandler_linux.cc File runtime/bin/eventhandler_linux.cc (right): https://codereview.chromium.org/12319067/diff/1/runtime/bin/eventhandler_linux.cc#newcode328 runtime/bin/eventhandler_linux.cc:328: if (events == (EPOLLHUP | EPOLLERR)) { So ...

7 years, 10 months ago (2013-02-22 09:29:06 UTC) #2

Anders Johnsen

PTAL https://codereview.chromium.org/12319067/diff/1/runtime/bin/eventhandler_linux.cc File runtime/bin/eventhandler_linux.cc (right): https://codereview.chromium.org/12319067/diff/1/runtime/bin/eventhandler_linux.cc#newcode328 runtime/bin/eventhandler_linux.cc:328: if (events == (EPOLLHUP | EPOLLERR)) { On ...

7 years, 10 months ago (2013-02-22 09:33:17 UTC) #3

Mads Ager (google)

LGTM https://codereview.chromium.org/12319067/diff/4002/runtime/bin/eventhandler_linux.cc File runtime/bin/eventhandler_linux.cc (right): https://codereview.chromium.org/12319067/diff/4002/runtime/bin/eventhandler_linux.cc#newcode318 runtime/bin/eventhandler_linux.cc:318: // Assert we never get a EPOLLHUP on ...

7 years, 10 months ago (2013-02-22 09:39:00 UTC) #4

Søren Gjesse

lgtm https://codereview.chromium.org/12319067/diff/4002/runtime/bin/eventhandler_linux.cc File runtime/bin/eventhandler_linux.cc (right): https://codereview.chromium.org/12319067/diff/4002/runtime/bin/eventhandler_linux.cc#newcode318 runtime/bin/eventhandler_linux.cc:318: // Assert we never get a EPOLLHUP on ...

7 years, 10 months ago (2013-02-22 09:39:05 UTC) #5

Anders Johnsen

Committed patchset #3 manually as r18873 (presubmit successful).

7 years, 10 months ago (2013-02-22 09:51:17 UTC) #6

Anders Johnsen

7 years, 6 months ago (2013-06-11 12:14:53 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/12319067/diff/4002/runtime/bin/eventhandler_l...
File runtime/bin/eventhandler_linux.cc (right):

https://codereview.chromium.org/12319067/diff/4002/runtime/bin/eventhandler_l...
runtime/bin/eventhandler_linux.cc:318: // Assert we never get a EPOLLHUP on a
non-piping socket.
On 2013/02/22 09:39:00, Mads Ager wrote:
> non-pipe file descriptor

Done.

https://codereview.chromium.org/12319067/diff/4002/runtime/bin/eventhandler_l...
runtime/bin/eventhandler_linux.cc:318: // Assert we never get a EPOLLHUP on a
non-piping socket.
On 2013/02/22 09:39:05, Søren Gjesse wrote:
> a -> an

Done.

https://codereview.chromium.org/12319067/diff/4002/tests/standalone/standalon...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/12319067/diff/4002/tests/standalone/standalon...
tests/standalone/standalone.status:18: [ $runtime == vm && ( $system == macos ||
$system == windows ) ]
On 2013/02/22 09:39:00, Mads Ager wrote:
> This seems a little optimistic, but it is the right thing to do to figure out
> what is still left. :-)

Done.

Expand Messages | Collapse Messages