Issue 12319017: Remove optional CompileType parameter in the constructor of Value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12319017: Remove optional CompileType parameter in the constructor of Value. (Closed)

Created:
7 years, 10 months ago by Florian Schneider

Modified:
7 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove optional CompileType parameter in the constructor of Value. It is only needed in one place inside the Value class anyway, so there is no reason to have it visible to the outside. Committed: https://code.google.com/p/dart/source/detail?r=18767

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	runtime/vm/intermediate_language.h	View		2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years, 10 months ago (2013-02-20 17:11:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18767 (presubmit successful).

Expand Messages | Collapse Messages