Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 12319010: Do not allow streams to send events during state-change callbacks. (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change Stream callbacks. During a stat-change callback, events can't be fired. Any events added will be delayed. When both the subscription state and the pause state has changed in a single operation, only the subscription state change callback is called. After calling _close on a Stream (close on a StreamController/scheduling a Done event), the pause-state change callback will no longer be called. All necessary pause handling will be done internally in the Stream, since the stream controller can't add any new events anyway. Committed: https://code.google.com/p/dart/source/detail?r=18748

Patch Set 1 #

Patch Set 2 : More changes to Stream. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -21 lines) Patch
M sdk/lib/async/stream_impl.dart View 1 14 chunks +56 lines, -16 lines 2 comments Download
M tests/lib/async/slow_consumer_test.dart View 1 5 chunks +15 lines, -5 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
Will need to run more tests.
7 years, 10 months ago (2013-02-20 12:25:23 UTC) #1
Anders Johnsen
STV!!! https://codereview.chromium.org/12319010/diff/2001/sdk/lib/async/stream_impl.dart File sdk/lib/async/stream_impl.dart (right): https://codereview.chromium.org/12319010/diff/2001/sdk/lib/async/stream_impl.dart#newcode234 sdk/lib/async/stream_impl.dart:234: Extra space. https://codereview.chromium.org/12319010/diff/2001/sdk/lib/async/stream_impl.dart#newcode474 sdk/lib/async/stream_impl.dart:474: // A single-stream is ...
7 years, 10 months ago (2013-02-20 12:42:02 UTC) #2
Lasse Reichstein Nielsen
7 years, 10 months ago (2013-02-20 12:45:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r18748 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698