Issue 1231893004: Always pass absolute paths to dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1231893004: Always pass absolute paths to dart2js. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Always pass absolute paths to dart2js. It can choke on relative paths in surprising ways. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/7d57d8b1cfeb244b8d60242b1cd4f7488e5aa831

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	lib/src/barback/dart2js_transformer.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	lib/src/dart.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 5 months ago (2015-07-09 21:07:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7d57d8b1cfeb244b8d60242b1cd4f7488e5aa831 (presubmit successful).