Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12318031: Move json, uri, utf and crypto libraries into the VM. (Closed)

Created:
7 years, 10 months ago by siva
Modified:
7 years, 10 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move json, uri, utf and crypto libraries into the VM. This should ensure that we would not need a patch per embedder for these libraries in case somebody decides to patch these. Committed: https://code.google.com/p/dart/source/detail?r=18865

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 10

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1699 lines, -1770 lines) Patch
M runtime/bin/bin.gypi View 1 2 3 6 chunks +0 lines, -216 lines 0 comments Download
M runtime/bin/builtin.h View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download
M runtime/bin/builtin.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/builtin_gen_snapshot.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/builtin_nolib.cc View 1 2 3 2 chunks +1 line, -5 lines 0 comments Download
D runtime/bin/crypto_sources.gypi View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
M runtime/bin/dartutils.h View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 2 3 4 chunks +1 line, -33 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 2 3 1 chunk +1 line, -10 lines 0 comments Download
D runtime/bin/json_sources.gypi View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/bin/main.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
D runtime/bin/uri_sources.gypi View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
D runtime/bin/utf_sources.gypi View 1 2 3 1 chunk +0 lines, -24 lines 0 comments Download
D runtime/lib/crypto/crypto_vm.dart View 1 2 3 1 chunk +0 lines, -127 lines 0 comments Download
D runtime/lib/utf/utf_vm.dart View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/bootstrap.h View 1 2 3 2 chunks +11 lines, -3 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 2 3 3 chunks +31 lines, -3 lines 0 comments Download
M runtime/vm/bootstrap_nocorelib.cc View 1 2 3 3 chunks +25 lines, -1 line 0 comments Download
M runtime/vm/object.h View 1 2 3 1 chunk +12 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 9 chunks +112 lines, -21 lines 0 comments Download
M runtime/vm/object_store.h View 1 2 3 6 chunks +49 lines, -17 lines 0 comments Download
M runtime/vm/object_store.cc View 1 2 3 1 chunk +8 lines, -3 lines 0 comments Download
M runtime/vm/symbols.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/unit_test.cc View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/vm.gypi View 1 2 3 6 chunks +212 lines, -0 lines 0 comments Download
M sdk/lib/crypto/crypto.dart View 1 2 3 1 chunk +1 line, -139 lines 0 comments Download
A sdk/lib/crypto/crypto_base.dart View 1 chunk +144 lines, -0 lines 0 comments Download
A + sdk/lib/crypto/crypto_sources.gypi View 1 chunk +10 lines, -10 lines 0 comments Download
M sdk/lib/json/json.dart View 1 2 3 1 chunk +1 line, -798 lines 0 comments Download
A sdk/lib/json/json_base.dart View 1 chunk +802 lines, -0 lines 0 comments Download
A + sdk/lib/json/json_sources.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/uri/uri.dart View 1 2 3 1 chunk +1 line, -254 lines 0 comments Download
A sdk/lib/uri/uri_base.dart View 1 chunk +259 lines, -0 lines 0 comments Download
A + sdk/lib/uri/uri_sources.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
A + sdk/lib/utf/utf_sources.gypi View 1 2 1 chunk +7 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
siva
7 years, 10 months ago (2013-02-21 03:24:09 UTC) #1
siva
sync to TOT.
7 years, 10 months ago (2013-02-21 18:40:39 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/12318031/diff/2005/runtime/vm/bootstrap.cc File runtime/vm/bootstrap.cc (right): https://codereview.chromium.org/12318031/diff/2005/runtime/vm/bootstrap.cc#newcode87 runtime/vm/bootstrap.cc:87: RawScript* Bootstrap::LoadMirrorsScript(bool patch) { Sorting? https://codereview.chromium.org/12318031/diff/2005/runtime/vm/bootstrap.h File ...
7 years, 10 months ago (2013-02-22 00:39:38 UTC) #3
siva
https://codereview.chromium.org/12318031/diff/2005/runtime/vm/bootstrap.cc File runtime/vm/bootstrap.cc (right): https://codereview.chromium.org/12318031/diff/2005/runtime/vm/bootstrap.cc#newcode87 runtime/vm/bootstrap.cc:87: RawScript* Bootstrap::LoadMirrorsScript(bool patch) { Fixed teh sort order. On ...
7 years, 10 months ago (2013-02-22 01:01:19 UTC) #4
siva
7 years, 10 months ago (2013-02-22 01:25:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 manually as r18865 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698