Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 12317130: Remove deprecated IllegalJSRegExpException class. (Closed)

Created:
7 years, 10 months ago by floitsch
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove deprecated IllegalJSRegExpException class. Committed: https://code.google.com/p/dart/source/detail?r=19297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -51 lines) Patch
M pkg/unittest/lib/src/core_matchers.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/unittest/test/matchers_test.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/lib/regexp.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/lib/regexp_jsc.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/vm/exceptions.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M sdk/lib/core/exceptions.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
7 years, 10 months ago (2013-02-26 19:12:59 UTC) #1
srdjan
lgtm
7 years, 10 months ago (2013-02-26 19:16:11 UTC) #2
Lasse Reichstein Nielsen
lgtm
7 years, 9 months ago (2013-02-28 11:28:41 UTC) #3
floitsch
7 years, 9 months ago (2013-03-01 12:16:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19297 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698