Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 12317107: ceil/floor/truncate/round return integers. (Closed)

Created:
7 years, 10 months ago by floitsch
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org, Florian Schneider
Visibility:
Public.

Description

ceil/floor/truncate/round return integers. This CL supercedes https://codereview.chromium.org/11748016/ Committed: https://code.google.com/p/dart/source/detail?r=19810

Patch Set 1 #

Patch Set 2 : Some fixes from CL 11748016. #

Total comments: 2

Patch Set 3 : Update status files and other minor tweaks. #

Patch Set 4 : Reupload due to error. #

Patch Set 5 : Reupload due to error2 #

Patch Set 6 : Reupload due to error3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1350 lines, -137 lines) Patch
pkg/fixnum/test/int_64_vm_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/number_format.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/lib/src/date_format_field.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/date_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/double.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M runtime/lib/integers.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M samples/logo/logo.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/solar3d/web/solar.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/Views.dart View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M samples/swarm/swarm_ui_lib/layout/GridLayout.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M samples/swarm/swarm_ui_lib/layout/GridTracks.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/touch/Momentum.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M samples/swarm/swarm_ui_lib/view/PagedViews.dart View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M samples/third_party/dromaeo/Dromaeo.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/third_party/dromaeo/common/Math2.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_number.dart View 4 chunks +15 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tools/mini_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/date_time.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/double.dart View 2 chunks +52 lines, -10 lines 0 comments Download
M sdk/lib/core/int.dart View 2 chunks +14 lines, -2 lines 0 comments Download
M sdk/lib/core/num.dart View 1 2 2 chunks +58 lines, -13 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M tests/corelib/compare_to2_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A tests/corelib/double_ceil2_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A tests/corelib/double_ceil_test.dart View 1 chunk +80 lines, -0 lines 0 comments Download
A tests/corelib/double_ceil_to_double_test.dart View 1 chunk +91 lines, -0 lines 0 comments Download
A tests/corelib/double_floor2_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A tests/corelib/double_floor_test.dart View 1 chunk +80 lines, -0 lines 0 comments Download
A tests/corelib/double_floor_to_double_test.dart View 1 chunk +83 lines, -0 lines 0 comments Download
A tests/corelib/double_round2_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A tests/corelib/double_round_test.dart View 1 chunk +80 lines, -0 lines 0 comments Download
A tests/corelib/double_round_to_double_test.dart View 1 2 1 chunk +91 lines, -0 lines 0 comments Download
A tests/corelib/double_truncate2_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A tests/corelib/double_truncate_test.dart View 1 chunk +88 lines, -0 lines 0 comments Download
A tests/corelib/double_truncate_to_double_test.dart View 1 chunk +83 lines, -0 lines 0 comments Download
A tests/corelib/int_ceil_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A tests/corelib/int_ceil_to_double_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A tests/corelib/int_floor_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A tests/corelib/int_floor_to_double_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A tests/corelib/int_round_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A tests/corelib/int_round_to_double_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A tests/corelib/int_to_int_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A tests/corelib/int_truncate_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A tests/corelib/int_truncate_to_double_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
M tests/language/arithmetic_test.dart View 1 2 5 chunks +60 lines, -61 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
7 years, 10 months ago (2013-02-25 22:40:06 UTC) #1
Lasse Reichstein Nielsen
LGTM.
7 years, 10 months ago (2013-02-26 14:04:09 UTC) #2
floitsch
Adding srdjan who was opposing the first attempt. I hope this approach is more acceptable.
7 years, 10 months ago (2013-02-26 15:26:10 UTC) #3
srdjan
LGTM with comments and after checking that there are no benchmark regressions. https://codereview.chromium.org/12317107/diff/2001/runtime/lib/double.dart File runtime/lib/double.dart ...
7 years, 10 months ago (2013-02-26 16:35:26 UTC) #4
floitsch
https://codereview.chromium.org/12317107/diff/2001/runtime/lib/double.dart File runtime/lib/double.dart (right): https://codereview.chromium.org/12317107/diff/2001/runtime/lib/double.dart#newcode111 runtime/lib/double.dart:111: double truncateToDouble() native "Double_truncate"; On 2013/02/26 16:35:26, srdjan wrote: ...
7 years, 10 months ago (2013-02-26 17:44:35 UTC) #5
floitsch
7 years, 9 months ago (2013-03-11 18:55:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 manually as r19810 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698