Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 12317100: Don't use strange DNS names HTTP proxy test in Windows (Closed)

Created:
7 years, 10 months ago by Søren Gjesse
Modified:
7 years, 10 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't use strange DNS names HTTP proxy test in Windows This is an experiment to see if the strange DNS names are related to the long running time of this test on Windows. It almost always takes more that 30 sec. on our Windows bots. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18977

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -16 lines) Patch
M tests/standalone/io/http_proxy_test.dart View 2 chunks +39 lines, -16 lines 4 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 10 months ago (2013-02-25 16:21:23 UTC) #1
Anders Johnsen
LGTM https://codereview.chromium.org/12317100/diff/1/tests/standalone/io/http_proxy_test.dart File tests/standalone/io/http_proxy_test.dart (right): https://codereview.chromium.org/12317100/diff/1/tests/standalone/io/http_proxy_test.dart#newcode196 tests/standalone/io/http_proxy_test.dart:196: "PROXY localhost:${proxyServer.port}; PROXY hede.hule.hest:8080", I still see a ...
7 years, 10 months ago (2013-02-25 16:26:26 UTC) #2
Søren Gjesse
https://codereview.chromium.org/12317100/diff/1/tests/standalone/io/http_proxy_test.dart File tests/standalone/io/http_proxy_test.dart (right): https://codereview.chromium.org/12317100/diff/1/tests/standalone/io/http_proxy_test.dart#newcode196 tests/standalone/io/http_proxy_test.dart:196: "PROXY localhost:${proxyServer.port}; PROXY hede.hule.hest:8080", On 2013/02/25 16:26:26, Anders Johnsen ...
7 years, 10 months ago (2013-02-25 16:28:57 UTC) #3
Søren Gjesse
7 years, 10 months ago (2013-02-25 16:29:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698