Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 12317043: Weaken a bogus assertion in use list verification. (Closed)

Created:
7 years, 10 months ago by Kevin Millikin (Google)
Modified:
7 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Weaken a bogus assertion in use list verification. It is allowed for a phi to refer to itself as input without violating properties of SSA form. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/flow_graph.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
7 years, 10 months ago (2013-02-21 13:52:20 UTC) #1
Florian Schneider
LGTM.
7 years, 10 months ago (2013-02-21 13:53:55 UTC) #2
Kevin Millikin (Google)
7 years, 10 months ago (2013-02-21 13:56:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18830 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698