Issue 12317011: Inline ByteArray._setIndexed in the flow graph optimizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12317011: Inline ByteArray._setIndexed in the flow graph optimizer. (Closed)

Created:
7 years, 10 months ago by Florian Schneider

Modified:
7 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Inline ByteArray._setIndexed in the flow graph optimizer. The procedure is very similar to the existing inlining of []=. The only difference is that the ICData collected are different: The number of arguments tested is 1 when calling _setIndexed, and it is 3 for []=. To make it work, I construct an ICData object for the stored value (argument 2) if it is needed for a check.

Patch Set 1 #

Patch Set 2 : updated intrinsifier #

Patch Set 3 : #

Patch Set 4 : fixed assert with ICData::New #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -982 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3	4 chunks	+73 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1	2 chunks	+1 line, -21 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1	3 chunks	+1 line, -91 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1	4 chunks	+1 line, -404 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1	3 chunks	+1 line, -91 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	4 chunks	+1 line, -372 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years, 10 months ago (2013-02-21 11:35:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r18818 (presubmit successful).

Expand Messages | Collapse Messages