Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1231633011: Add an AnalysisOptionsProvider to analyzer (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -0 lines) Patch
A pkg/analyzer/lib/source/analysis_options_provider.dart View 1 1 chunk +52 lines, -0 lines 0 comments Download
A pkg/analyzer/test/source/analysis_options_provider_test.dart View 1 chunk +64 lines, -0 lines 0 comments Download
M pkg/analyzer/test/source/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Cutch
5 years, 5 months ago (2015-07-17 20:26:05 UTC) #2
pquitslund
lgtm https://codereview.chromium.org/1231633011/diff/1/pkg/analyzer/lib/source/analysis_options_provider.dart File pkg/analyzer/lib/source/analysis_options_provider.dart (right): https://codereview.chromium.org/1231633011/diff/1/pkg/analyzer/lib/source/analysis_options_provider.dart#newcode1 pkg/analyzer/lib/source/analysis_options_provider.dart:1: // Copyright (c) 2014, the Dart project authors. ...
5 years, 5 months ago (2015-07-17 20:31:32 UTC) #3
Cutch
https://codereview.chromium.org/1231633011/diff/1/pkg/analyzer/lib/source/analysis_options_provider.dart File pkg/analyzer/lib/source/analysis_options_provider.dart (right): https://codereview.chromium.org/1231633011/diff/1/pkg/analyzer/lib/source/analysis_options_provider.dart#newcode1 pkg/analyzer/lib/source/analysis_options_provider.dart:1: // Copyright (c) 2014, the Dart project authors. Please ...
5 years, 5 months ago (2015-07-17 20:33:49 UTC) #4
Cutch
Committed patchset #2 (id:20001) manually as 4bf66ce9127441e6ce3679c19cf5e9f8bd9a36df (presubmit successful).
5 years, 5 months ago (2015-07-17 20:34:08 UTC) #5
Brian Wilkerson
5 years, 5 months ago (2015-07-17 20:38:45 UTC) #6
Message was sent while issue was closed. 
LGTM, except for replacing 'ignore' with 'exclude'.

Powered by Google App Engine
This is Rietveld 408576698