Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 12316155: Make arg parser return growable list of rest arguments. (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make arg parser return growable list of rest arguments. This allows the user to remove them when he's done, which is what is currently being done. Committed: https://code.google.com/p/dart/source/detail?r=19119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/args/lib/src/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/pub.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
TBR
7 years, 10 months ago (2013-02-27 09:29:31 UTC) #1
Lasse Reichstein Nielsen
Committed patchset #1 manually as r19119 (presubmit successful).
7 years, 10 months ago (2013-02-27 09:48:25 UTC) #2
floitsch
7 years, 10 months ago (2013-02-27 10:08:52 UTC) #3
Message was sent while issue was closed.
LGTM, but we should probably fix this.

Powered by Google App Engine
This is Rietveld 408576698