Issue 12316139: Converting dart:html to use DateTime rather than Date.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12316139: Converting dart:html to use DateTime rather than Date. (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 9 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Converting dart:html to use DateTime rather than Date. We had been exposing JS Date objects as Dart Dates, but it appears to never actually worked. Switched over to DateTime and added a converter for it. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19107

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -30 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	22 chunks	+45 lines, -21 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/fileapi_test.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/html/input_element_test.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/dom/src/dart2js_Conversions.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm. If you can, declare private fields with different names and the same @JSName These ...

7 years, 9 months ago (2013-02-27 02:27:03 UTC) #2

blois

7 years, 9 months ago (2013-02-27 02:57:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19107 (presubmit successful).

Expand Messages | Collapse Messages