Issue 12316126: pkg/logging: adding Type information

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12316126: pkg/logging: adding Type information (Closed)

Created:
7 years, 10 months ago by kevmoo-old

Modified:
7 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang), gram

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

make dartdoc and editor happy added type to Logger.level setter added type to Logger.root Committed: https://code.google.com/p/dart/source/detail?r=19186

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	pkg/logging/lib/logging.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

kevmoo-old

All tests pass. I couldn't find someone who seems to "own" this. I don't have ...

7 years, 10 months ago (2013-02-26 16:59:29 UTC) #1

kevmoo-old

On 2013/02/26 18:48:30, Siggi Cherem (dart-lang) wrote: > lgtm I don't have a commit bit. ...

7 years, 10 months ago (2013-02-26 19:19:46 UTC) #3

Siggi Cherem (dart-lang)

7 years, 9 months ago (2013-02-27 23:43:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19186 (presubmit successful).