Issue 12316066: Update WebKit idl files after chrome roll

Issue 12316066: Update WebKit idl files after chrome roll (Closed)

Created:
7 years, 10 months ago by Mads Ager (google)

Modified:
7 years, 10 months ago

Reviewers:
Anton Muhin, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update WebKit idl files after chrome roll R=antonm@google.com,blois@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18889

Patch Set 1 #

Patch Set 2 : Remove deltaMode from WheelEvent template. #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+307 lines, -497 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		11 chunks	+106 lines, -218 lines	1 comment	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		11 chunks	+132 lines, -211 lines	0 comments	Download
M	third_party/WebCore/Modules/mediastream/MediaStream.idl	View		1 chunk	+1 line, -0 lines	0 comments	Download
D	third_party/WebCore/Modules/mediastream/MediaStreamList.idl	View		1 chunk	+0 lines, -33 lines	0 comments	Download
M	third_party/WebCore/Modules/mediastream/RTCPeerConnection.idl	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	third_party/WebCore/Modules/webaudio/PannerNode.idl	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	third_party/WebCore/README	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebCore/css/CSSPrimitiveValue.idl	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebCore/dom/EventTarget.idl	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	third_party/WebCore/dom/WheelEvent.idl	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	third_party/WebCore/html/HTMLEmbedElement.idl	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	third_party/WebCore/html/HTMLMediaElement.idl	View		2 chunks	+10 lines, -5 lines	0 comments	Download
M	third_party/WebCore/html/MediaError.idl	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	third_party/WebCore/html/MediaKeyError.idl	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	third_party/WebCore/html/canvas/DOMPath.idl	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/WebCore/inspector/InjectedScriptHost.idl	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebCore/inspector/JavaScriptCallFrame.idl	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/WebCore/page/DOMWindow.idl	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	third_party/WebCore/svg/SVGElementInstance.idl	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	third_party/WebCore/testing/Internals.idl	View		4 chunks	+12 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_WheelEvent.darttemplate	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

Pete, I removed the deltaMode getter from the WheelEvent template to avoid having two definitions ...

7 years, 10 months ago (2013-02-22 13:03:43 UTC) #2

Mads Ager (google)

Committed patchset #2 manually as r18889 (presubmit successful).

7 years, 10 months ago (2013-02-22 13:16:14 UTC) #4

blois

7 years, 10 months ago (2013-02-22 17:52:19 UTC) #5

Message was sent while issue was closed.

Opened bugs-
8712- Rename RtcdtmfSender and RtcdtmfToneChangeEvent classes
8713- Re-expose the WheelEvent.deltaMode polyfill

https://codereview.chromium.org/12316066/diff/2001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://codereview.chromium.org/12316066/diff/2001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:25344: -  int get deltaMode {
This is actually needed as a polyfill for browsers which do not support it. I
opened a bug to add it back.

Expand Messages | Collapse Messages