Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 12315140: Fix dartc break by removing re-export of fail from unittest; already in matcher.dart. (Closed)

Created:
7 years, 9 months ago by gram
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

TBR: Fix dartc break by removing re-export of fail from unittest; already in matcher.dart. Committed: https://code.google.com/p/dart/source/detail?r=19173

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/scheduled_test/lib/scheduled_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gram
7 years, 9 months ago (2013-02-27 21:16:01 UTC) #1
kevmoo-old
Beat me to it. lgtm
7 years, 9 months ago (2013-02-27 21:17:11 UTC) #2
Siggi Cherem (dart-lang)
lgtm
7 years, 9 months ago (2013-02-27 21:22:14 UTC) #3
gram
7 years, 9 months ago (2013-02-27 21:37:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19173 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698