Issue 12315129: Make File.readSync return only the bytes read

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12315129: Make File.readSync return only the bytes read (Closed)

Created:
7 years, 9 months ago by Søren Gjesse

Modified:
7 years, 9 months ago

Reviewers:
Mads Ager (google), Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make File.readSync return only the bytes read R=ager@google.com BUG=https://code.google.com/p/dart/issues/detail?id=8831 TEST=tests/standalone/io/file_test.dart Committed: https://code.google.com/p/dart/source/detail?r=19145

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -6 lines)			Patch
M	runtime/bin/file.cc	View	2 chunks	+19 lines, -6 lines	2 comments	Download
M	sdk/lib/io/file_impl.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/standalone/io/file_test.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM! https://codereview.chromium.org/12315129/diff/1/runtime/bin/file.cc File runtime/bin/file.cc (left): https://codereview.chromium.org/12315129/diff/1/runtime/bin/file.cc#oldcode184 runtime/bin/file.cc:184: Dart_SetField(external_array, I should have been beaten with a ...

7 years, 9 months ago (2013-02-27 15:02:36 UTC) #2

Søren Gjesse

Committed patchset #1 manually as r19145 (presubmit successful).

7 years, 9 months ago (2013-02-27 15:33:16 UTC) #3

Ivan Posva

7 years, 9 months ago (2013-02-27 18:18:56 UTC) #4

Message was sent while issue was closed.

DBC -ip

https://codereview.chromium.org/12315129/diff/1/runtime/bin/file.cc
File runtime/bin/file.cc (right):

https://codereview.chromium.org/12315129/diff/1/runtime/bin/file.cc#newcode1
runtime/bin/file.cc:1: // Copyright (c) 2013, the Dart project authors.  Please
see the AUTHORS file
No need to update.

Expand Messages | Collapse Messages