Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 12315102: Fix copy_dart to correctly put library comments BEFORE the library directive. (Closed)

Created:
7 years, 10 months ago by Andrei Mouravski
Modified:
7 years, 10 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix copy_dart to correctly put library comments BEFORE the library directive. Committed: https://code.google.com/p/dart/source/detail?r=19059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -13 lines) Patch
M sdk/lib/chrome/dart2js/chrome_dart2js.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/chrome/dartium/chrome_dartium.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/copy_dart.py View 4 chunks +14 lines, -3 lines 0 comments Download
M tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/chrome_dartium.darttemplate View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Andrei Mouravski
7 years, 10 months ago (2013-02-26 04:56:08 UTC) #1
blois
lgtm
7 years, 10 months ago (2013-02-26 16:47:37 UTC) #2
Andrei Mouravski
7 years, 10 months ago (2013-02-26 17:36:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19059 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698