Issue 12315087: Hook up simulator (if needed) when calling Dart code.

Issue 12315087: Hook up simulator (if needed) when calling Dart code. (Closed)

Created:
7 years, 10 months ago by regis

Modified:
7 years, 10 months ago

Reviewers:
zra, srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Hook up simulator (if needed) when calling Dart code. Merge identical InvokeDynamic and InvokeStatic to InvokeFunction. Remove redundant argument from InvokeClosure. Committed: https://code.google.com/p/dart/source/detail?r=18994

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -201 lines)			Patch
M	runtime/lib/function.cc	View	1 2 3	1 chunk	+1 line, -5 lines	0 comments	Download
M	runtime/lib/invocation_mirror.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/lib/isolate.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/ast.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_descriptors_test.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2 3	3 chunks	+8 lines, -14 lines	0 comments	Download
M	runtime/vm/code_generator_test.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/compiler.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2 3	18 chunks	+20 lines, -20 lines	0 comments	Download
M	runtime/vm/dart_entry.h	View	1 2 3	1 chunk	+18 lines, -24 lines	0 comments	Download
M	runtime/vm/dart_entry.cc	View	1 2 3	14 chunks	+47 lines, -83 lines	0 comments	Download
M	runtime/vm/dart_entry_test.cc	View	1 2 3	4 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/resolver_test.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm_test.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3	1 chunk	+7 lines, -10 lines	0 comments	Download
M	runtime/vm/stub_code_ia32_test.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_mips_test.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2 3	1 chunk	+7 lines, -10 lines	0 comments	Download
M	runtime/vm/stub_code_x64_test.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/unit_test.h	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/12315087/diff/6003/runtime/vm/dart_entry.h File runtime/vm/dart_entry.h (right): https://codereview.chromium.org/12315087/diff/6003/runtime/vm/dart_entry.h#newcode108 runtime/vm/dart_entry.h:108: // Invoke the specified instance function or static ...

7 years, 10 months ago (2013-02-25 18:18:19 UTC) #2

regis

Thanks https://codereview.chromium.org/12315087/diff/6003/runtime/vm/dart_entry.h File runtime/vm/dart_entry.h (right): https://codereview.chromium.org/12315087/diff/6003/runtime/vm/dart_entry.h#newcode108 runtime/vm/dart_entry.h:108: // Invoke the specified instance function or static ...

7 years, 10 months ago (2013-02-25 19:24:05 UTC) #3

regis

7 years, 10 months ago (2013-02-25 19:31:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r18994 (presubmit successful).

Expand Messages | Collapse Messages