Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12315059: Updated an error message to inform users that their packages were not installed (Closed)

Created:
7 years, 10 months ago by Andrei Mouravski
Modified:
7 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Updated an error message to inform users that their packages were not installed when their SDK version does not match. Committed: https://code.google.com/p/dart/source/detail?r=19026

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M utils/pub/entrypoint.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M utils/tests/pub/sdk_constraint_test.dart View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Andrei Mouravski
7 years, 10 months ago (2013-02-22 23:06:47 UTC) #1
nweiz
https://codereview.chromium.org/12315059/diff/1/utils/pub/entrypoint.dart File utils/pub/entrypoint.dart (right): https://codereview.chromium.org/12315059/diff/1/utils/pub/entrypoint.dart#newcode197 utils/pub/entrypoint.dart:197: "${sdk.version} and were NOT installed:\n" I'm pretty sure Bob ...
7 years, 10 months ago (2013-02-22 23:10:29 UTC) #2
Andrei Mouravski
https://codereview.chromium.org/12315059/diff/1/utils/pub/entrypoint.dart File utils/pub/entrypoint.dart (right): https://codereview.chromium.org/12315059/diff/1/utils/pub/entrypoint.dart#newcode197 utils/pub/entrypoint.dart:197: "${sdk.version} and were NOT installed:\n" On 2013/02/22 23:10:29, nweiz ...
7 years, 10 months ago (2013-02-22 23:17:11 UTC) #3
Andrei Mouravski
Let's try again.
7 years, 10 months ago (2013-02-23 00:07:55 UTC) #4
nweiz
lgtm
7 years, 10 months ago (2013-02-23 00:09:37 UTC) #5
Andrei Mouravski
7 years, 10 months ago (2013-02-26 03:12:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 manually as r19026 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698