Issue 12315017: Ignore definitions without uses in FlowGraphAllocator::CollectRepresentations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12315017: Ignore definitions without uses in FlowGraphAllocator::CollectRepresentations. (Closed)

Created:
7 years, 10 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ignore definitions that do not have SSA index in FlowGraphAllocator::CollectRepresentations. SSA building does not assign an index to definitions without uses and the rest of the allocator can cope with this treating output produced by such an instruction as temporary value. R=srdjan@google.com BUG=dart:8655 Committed: https://code.google.com/p/dart/source/detail?r=18793

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	runtime/vm/flow_graph_allocator.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

7 years, 10 months ago (2013-02-20 22:38:35 UTC) #3

Message was sent while issue was closed.

Committed manually as r18793 (presubmit successful).

Expand Messages | Collapse Messages