Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 12314153: dart:io | Rename File.name to File.path. (Closed)

Created:
7 years, 9 months ago by Bill Hesse
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Rename File.name to File.path. BUG=dartbug.com/8790 Committed: https://code.google.com/p/dart/source/detail?r=19144

Patch Set 1 #

Patch Set 2 : Remove stray line break. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -174 lines) Patch
M runtime/bin/builtin_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file.h View 2 chunks +11 lines, -11 lines 0 comments Download
M runtime/bin/file.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M runtime/bin/file_android.cc View 1 chunk +1 line, -1 line 1 comment Download
M runtime/bin/file_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file_patch.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M runtime/bin/file_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/io_patch.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/file.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 41 chunks +89 lines, -89 lines 0 comments Download
M sdk/lib/io/file_system_entity.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/dart_std_io_pipe_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/directory_error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/file_system_links_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/file_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_check_arguments_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/standalone/io/process_non_ascii_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_run_output_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/standalone/io/process_stderr_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_stdin_transform_unsubscribe_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_stdout_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/windows_environment_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/io.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
7 years, 9 months ago (2013-02-27 14:58:14 UTC) #1
Mads Ager (google)
LGTM
7 years, 9 months ago (2013-02-27 15:00:55 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/12314153/diff/2001/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/12314153/diff/2001/runtime/bin/file_android.cc#newcode171 runtime/bin/file_android.cc:171: off_t File::LengthFromPath(const char* name) { name -> path ...
7 years, 9 months ago (2013-02-27 15:20:30 UTC) #3
Bill Hesse
On 2013/02/27 15:20:30, Søren Gjesse wrote: > lgtm > > https://codereview.chromium.org/12314153/diff/2001/runtime/bin/file_android.cc > File runtime/bin/file_android.cc (right): ...
7 years, 9 months ago (2013-02-27 15:25:19 UTC) #4
Bill Hesse
7 years, 9 months ago (2013-02-27 15:26:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19144 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698