Issue 12314065: Reset http-parser instead of only setting _state, when we have handled a full request-response conv…

Issue 12314065: Reset http-parser instead of only setting _state, when we have handled a full request-response conv… (Closed)

Created:
7 years, 10 months ago by Anders Johnsen

Modified:
7 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reset http-parser instead of only setting _state, when we have handled a full request-response conversation. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18892

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -3 lines)			Patch
	M	sdk/lib/io/http_parser.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	A	tests/standalone/io/http_keep_alive_test.dart	View	1 2	1 chunk	+96 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM, good catch https://codereview.chromium.org/12314065/diff/3001/tests/standalone/io/http_keep_alive_test.dart File tests/standalone/io/http_keep_alive_test.dart (right): https://codereview.chromium.org/12314065/diff/3001/tests/standalone/io/http_keep_alive_test.dart#newcode43 tests/standalone/io/http_keep_alive_test.dart:43: .then((_) => getData(client, server.port, false, 100)) ...

7 years, 10 months ago (2013-02-22 14:06:41 UTC) #2

Anders Johnsen

Landing. https://codereview.chromium.org/12314065/diff/3001/tests/standalone/io/http_keep_alive_test.dart File tests/standalone/io/http_keep_alive_test.dart (right): https://codereview.chromium.org/12314065/diff/3001/tests/standalone/io/http_keep_alive_test.dart#newcode43 tests/standalone/io/http_keep_alive_test.dart:43: .then((_) => getData(client, server.port, false, 100)) On 2013/02/22 ...

7 years, 10 months ago (2013-02-22 14:07:48 UTC) #3

Anders Johnsen

7 years, 10 months ago (2013-02-22 14:08:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r18892 (presubmit successful).

Expand Messages | Collapse Messages