Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 12314055: Use browsers JSON.parse for parsing JSON (#3) (Closed)

Created:
7 years, 10 months ago by sra1
Modified:
7 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use browsers JSON.parse for parsing JSON (#3) Original CL: https://codereview.chromium.org//12114021 This version modified to take advantage of dart:json being moved to VM. Committed: https://code.google.com/p/dart/source/detail?r=18908

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -13 lines) Patch
A + runtime/lib/json_patch.dart View 1 chunk +3 lines, -6 lines 0 comments Download
A + runtime/lib/json_sources.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/vm.gypi View 4 chunks +41 lines, -0 lines 0 comments Download
A sdk/lib/_internal/compiler/implementation/lib/json_patch.dart View 1 chunk +91 lines, -0 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/json/json_base.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/corelib/json_leading_zeros_test.dart View 1 chunk +60 lines, -0 lines 0 comments Download
M tests/corelib/json_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
Hi Siva, I might submit and revert to test Dartium while I wait for your ...
7 years, 10 months ago (2013-02-22 04:32:35 UTC) #1
siva
The VM parts lgtm with one comment about not refactoring some of the code into ...
7 years, 10 months ago (2013-02-22 18:25:39 UTC) #2
sra1
7 years, 10 months ago (2013-02-22 19:21:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r18908 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698