Add test of crypto.getRandomValues.

Add test of crypto.getRandomValues.

Implemented this in Dartium and would like a regression test.

I'll update status files with information on the browsers where
this passes when the test looks good to you.

R=blois@google.com,antonm@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=18872

[Anton Muhin, 2013-02-21 12:40:43]

https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart
File tests/html/crypto_test.dart (right):

https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart#n...
tests/html/crypto_test.dart:11: useHtmlConfiguration();
please, use useHtmlIndividualConfiguration

https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart#n...
tests/html/crypto_test.dart:34: }, throws, reason: "Only typed array views with
integer types allowed");
nit: ' instead of ", please

[Mads Ager (google), 2013-02-21 13:38:57]

https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart
File tests/html/crypto_test.dart (right):

https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart#n...
tests/html/crypto_test.dart:11: useHtmlConfiguration();
On 2013/02/21 12:40:43, Anton Muhin wrote:
> please, use useHtmlIndividualConfiguration

But then I have to use 'group', right. And since I only have three small tests
which would fit in the same group, I'm not sure it buys us anything?

Pete, do you have any recommendations on that?

https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart#n...
tests/html/crypto_test.dart:34: }, throws, reason: "Only typed array views with
integer types allowed");
On 2013/02/21 12:40:43, Anton Muhin wrote:
> nit: ' instead of ", please

Done.

[blois, 2013-02-21 17:18:34]

On 2013/02/21 13:38:57, Mads Ager wrote:
> https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart
> File tests/html/crypto_test.dart (right):
> 
>
https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart#n...
> tests/html/crypto_test.dart:11: useHtmlConfiguration();
> On 2013/02/21 12:40:43, Anton Muhin wrote:
> > please, use useHtmlIndividualConfiguration
> 
> But then I have to use 'group', right. And since I only have three small tests
> which would fit in the same group, I'm not sure it buys us anything?
> 
> Pete, do you have any recommendations on that?
> 
>
https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart#n...
> tests/html/crypto_test.dart:34: }, throws, reason: "Only typed array views
with
> integer types allowed");
> On 2013/02/21 12:40:43, Anton Muhin wrote:
> > nit: ' instead of ", please
> 
> Done.

Normally I do not use the individual configuration when possible as it's a bit
slower (I think) and does require grouping.

The primary place we do use the individual configuration is when including
supported checks. This test will fail on at least IE9 since it does not support
typed arrays.

If crypto is not supported everywhere, then we should add supported checks and
flags- I believe the spec is still experimental so it should get experimental
flags as well. Feel free to open a bug for this if you'd like to avoid that
portion of the work.

If crypto is supported on IE9, but just not the typed arrays portion, feel free
to exclude that test by checking ArrayBuffer.supported.

In short- either open a bug for the supported checks or go ahead and add those,
and html.status will need to be updated for at a minimum IE9, but most likely
IE9, IE10 & Safari.

[Mads Ager (google), 2013-02-22 09:34:51]

On 2013/02/21 17:18:34, blois wrote:
> On 2013/02/21 13:38:57, Mads Ager wrote:
> > https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart
> > File tests/html/crypto_test.dart (right):
> > 
> >
>
https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart#n...
> > tests/html/crypto_test.dart:11: useHtmlConfiguration();
> > On 2013/02/21 12:40:43, Anton Muhin wrote:
> > > please, use useHtmlIndividualConfiguration
> > 
> > But then I have to use 'group', right. And since I only have three small
tests
> > which would fit in the same group, I'm not sure it buys us anything?
> > 
> > Pete, do you have any recommendations on that?
> > 
> >
>
https://codereview.chromium.org/12314030/diff/1/tests/html/crypto_test.dart#n...
> > tests/html/crypto_test.dart:34: }, throws, reason: "Only typed array views
> with
> > integer types allowed");
> > On 2013/02/21 12:40:43, Anton Muhin wrote:
> > > nit: ' instead of ", please
> > 
> > Done.
> 
> Normally I do not use the individual configuration when possible as it's a bit
> slower (I think) and does require grouping.
> 
> The primary place we do use the individual configuration is when including
> supported checks. This test will fail on at least IE9 since it does not
support
> typed arrays.
> 
> If crypto is not supported everywhere, then we should add supported checks and
> flags- I believe the spec is still experimental so it should get experimental
> flags as well. Feel free to open a bug for this if you'd like to avoid that
> portion of the work.
> 
> If crypto is supported on IE9, but just not the typed arrays portion, feel
free
> to exclude that test by checking ArrayBuffer.supported.
> 
> In short- either open a bug for the supported checks or go ahead and add
those,
> and html.status will need to be updated for at a minimum IE9, but most likely
> IE9, IE10 & Safari.

Thanks Pete. I would be great if you could add the supported checks and flags
for this one. If you add me to the review I'll be in a much better position to
do this myself next time. :)

I file: http://dartbug.com/8703

Updated the status file. crypto.getRandomValues is supported only on webkit
browsers. ff has a crypto object but different methods. opera and ie does not
have the crypto object.

[Mads Ager (google), 2013-02-22 09:41:10]

Committed patchset #3 manually as r18872 (presubmit successful).