Issue 12313148: Proper support for typedefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12313148: Proper support for typedefs. (Closed)

Created:
7 years, 9 months ago by Anton Muhin

Modified:
7 years, 9 months ago

Reviewers:
podivilov, Mads Ager (google), sra1, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Proper support for typedefs. And allow them in WebKit IDLs. R=ager@google.com,blois@gogole.com,podivilov@chromium.org,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=19146

Patch Set 1 #

Total comments: 3

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -2 lines)			Patch
M	tools/dom/scripts/databasebuilder.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/idlnode.py	View	1 chunk	+2 lines, -0 lines	3 comments	Download
M	tools/dom/scripts/idlparser.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM with typo fixed. https://codereview.chromium.org/12313148/diff/1/tools/dom/scripts/idlnode.py File tools/dom/scripts/idlnode.py (right): https://codereview.chromium.org/12313148/diff/1/tools/dom/scripts/idlnode.py#newcode265 tools/dom/scripts/idlnode.py:265: self.typeDefs.exted(module.typeDefs) extend

7 years, 9 months ago (2013-02-27 15:47:22 UTC) #2

Anton Muhin

Committed patchset #1 manually as r19146 (presubmit successful).

7 years, 9 months ago (2013-02-27 15:48:43 UTC) #3

Anton Muhin

7 years, 9 months ago (2013-02-27 15:48:48 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12313148/diff/1/tools/dom/scripts/idlnode.py
File tools/dom/scripts/idlnode.py (right):

https://codereview.chromium.org/12313148/diff/1/tools/dom/scripts/idlnode.py#...
tools/dom/scripts/idlnode.py:265: self.typeDefs.exted(module.typeDefs)
On 2013/02/27 15:47:22, Mads Ager wrote:
> extend

thanks!

https://codereview.chromium.org/12313148/diff/1/tools/dom/scripts/idlnode.py#...
tools/dom/scripts/idlnode.py:265: self.typeDefs.exted(module.typeDefs)
On 2013/02/27 15:47:22, Mads Ager wrote:
> extend

thanks!

Expand Messages | Collapse Messages