Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 12313146: dart:io | Fix issue 8795, (Raw)SecureSocket loses data when close() is called. (Closed)

Created:
7 years, 9 months ago by Bill Hesse
Modified:
7 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Fix issue 8795, (Raw)SecureSocket loses data when close() is called. BUG=dartbug.com/8795 Committed: https://code.google.com/p/dart/source/detail?r=19133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M sdk/lib/io/secure_socket.dart View 6 chunks +15 lines, -10 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_pause_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
The Windows failures are not addressed by this fix, and the bug will remain open ...
7 years, 9 months ago (2013-02-27 12:23:56 UTC) #1
Søren Gjesse
lgtm
7 years, 9 months ago (2013-02-27 12:54:09 UTC) #2
Bill Hesse
7 years, 9 months ago (2013-02-27 13:23:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19133 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698