Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 12313105: Change the HTTP header field names to lowercase (Closed)

Created:
7 years, 9 months ago by Søren Gjesse
Modified:
7 years, 9 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the HTTP header field names to lowercase This simplifies the code and avoids duplicated constants in different cases. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -97 lines) Patch
M sdk/lib/io/http.dart View 12 chunks +68 lines, -64 lines 0 comments Download
M sdk/lib/io/http_headers.dart View 13 chunks +31 lines, -30 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 9 months ago (2013-02-25 15:05:56 UTC) #1
Anders Johnsen
LGTM! Yay!
7 years, 9 months ago (2013-02-25 15:07:47 UTC) #2
Søren Gjesse
7 years, 9 months ago (2013-02-25 15:10:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18971 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698