Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 12313033: Revert "Change the SSA construction pass to also construct def-use chains." (Closed)

Created:
7 years, 10 months ago by Kevin Millikin (Google)
Modified:
7 years, 10 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Change the SSA construction pass to also construct def-use chains." This reverts svn revision 18813 due to dart2js test failures. TBR=kasperl@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18817

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -57 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph.h View 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/flow_graph.cc View 6 chunks +154 lines, -24 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 4 chunks +13 lines, -28 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
7 years, 10 months ago (2013-02-21 11:06:21 UTC) #1
kasperl
LGTM :-(
7 years, 10 months ago (2013-02-21 11:06:42 UTC) #2
Kevin Millikin (Google)
7 years, 10 months ago (2013-02-21 11:06:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18817 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698