Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 12313021: - Disable source_filter.gypi. (Closed)

Created:
7 years, 10 months ago by Ivan Posva
Modified:
7 years, 10 months ago
Reviewers:
podivilov1, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Disable source_filter.gypi. - Adjust some more OS dependent files. Committed: https://code.google.com/p/dart/source/detail?r=18797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M runtime/dart-runtime.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/debuginfo_android.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/debuginfo_linux.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/gdbjit_android.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M runtime/vm/gdbjit_linux.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M tools/gyp/all.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
7 years, 10 months ago (2013-02-20 21:53:46 UTC) #1
siva
lgtm
7 years, 10 months ago (2013-02-20 23:09:25 UTC) #2
Ivan Posva
7 years, 10 months ago (2013-02-20 23:40:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18797 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698