Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1231083004: Fix X64 build by switching from near jumps to far jumps (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix X64 build by switching from near jumps to far jumps BUG= Committed: https://github.com/dart-lang/sdk/commit/f2bdf68919aca5bcfed7a8dea7fcc92279e30902

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M runtime/vm/intrinsifier_x64.cc View 7 chunks +8 lines, -8 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
TBR
5 years, 5 months ago (2015-07-10 20:03:18 UTC) #2
Cutch
Committed patchset #1 (id:1) manually as f2bdf68919aca5bcfed7a8dea7fcc92279e30902 (presubmit successful).
5 years, 5 months ago (2015-07-10 20:03:28 UTC) #3
srdjan
LGTMwC https://codereview.chromium.org/1231083004/diff/1/runtime/vm/intrinsifier_x64.cc File runtime/vm/intrinsifier_x64.cc (right): https://codereview.chromium.org/1231083004/diff/1/runtime/vm/intrinsifier_x64.cc#newcode1242 runtime/vm/intrinsifier_x64.cc:1242: __ j(NOT_EQUAL, not_double_smi, Assembler::kFarJump); Just remove argument (default ...
5 years, 5 months ago (2015-07-10 20:07:15 UTC) #4
Cutch
5 years, 5 months ago (2015-07-10 20:09:59 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1231083004/diff/1/runtime/vm/intrinsifier_x64.cc
File runtime/vm/intrinsifier_x64.cc (right):

https://codereview.chromium.org/1231083004/diff/1/runtime/vm/intrinsifier_x64...
runtime/vm/intrinsifier_x64.cc:1242: __ j(NOT_EQUAL, not_double_smi,
Assembler::kFarJump);
On 2015/07/10 20:07:15, srdjan wrote:
> Just remove argument (default is FarJump), since that is how it is done in the
> rest of the file. Here and in other places where appropriate.

Done here: https://codereview.chromium.org/1234443005/

Powered by Google App Engine
This is Rietveld 408576698