Added ability for test cases to return Futures.

Added ability for test cases to return Futures.
Committed: https://code.google.com/p/dart/source/detail?r=19087

[Siggi Cherem (dart-lang), 2013-02-26 00:25:29]

lgtm, but see my question below about defer

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:116: * A variation on this is
expectAsyncUntilX(); this takes a callback as the first
80 col

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:125: * test that may be invoked via an [Isolate]
(for example, with Timer.run()],
rephrase: 'via an [Isolate]' sounds strange.

In the browser for example Timer.run uses window.setTimout. You also have
futures for XHR requests. 

How about  'may be in voked from a top-level context'?

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:703: (new Future.immediate(null)).then((_) =>
callback());
I wonder if anything depends on the old behavior here.

In dart2js this will do a setTimeout(0) -- (which I hope gets fixed soon), but
that will be at the beginning of the next eventloop. The old logic with ports
was guaranteed to be at the end of the same event-loop.

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/test/unittest_te...
File pkg/unittest/test/unittest_test.dart (right):

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/test/unittest_te...
pkg/unittest/test/unittest_test.dart:23: return (new
Future.immediate(null)).then((_)=>guardAsync(fn));
style nit: add spaces around =>

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/test/unittest_te...
pkg/unittest/test/unittest_test.dart:270: } else if (testName == 'test returning
future using isolate (Timer)') {
nit: I'd just say '... future using Timer'?

[gram, 2013-02-26 22:02:27]

Committed patchset #2 manually as r19087 (presubmit successful).

[gram, 2013-03-04 19:51:52]

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:116: * A variation on this is
expectAsyncUntilX(); this takes a callback as the first
On 2013/02/26 00:25:29, Siggi Cherem (dart-lang) wrote:
> 80 col

Done.

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:125: * test that may be invoked via an [Isolate]
(for example, with Timer.run()],
On 2013/02/26 00:25:29, Siggi Cherem (dart-lang) wrote:
> rephrase: 'via an [Isolate]' sounds strange.
> 
> In the browser for example Timer.run uses window.setTimout. You also have
> futures for XHR requests. 
> 
> How about  'may be in voked from a top-level context'?

Done.

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:703: (new Future.immediate(null)).then((_) =>
callback());
On 2013/02/26 00:25:29, Siggi Cherem (dart-lang) wrote:
> I wonder if anything depends on the old behavior here.
> 
> In dart2js this will do a setTimeout(0) -- (which I hope gets fixed soon), but
> that will be at the beginning of the next eventloop. The old logic with ports
> was guaranteed to be at the end of the same event-loop. 

I've run all tests in vm (checked/unchecked) and all unchecked in dart2js/d8 and
dart2js/drt, plus quite a few in dart2js/drt checked, with no issues.

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/test/unittest_te...
File pkg/unittest/test/unittest_test.dart (right):

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/test/unittest_te...
pkg/unittest/test/unittest_test.dart:23: return (new
Future.immediate(null)).then((_)=>guardAsync(fn));
On 2013/02/26 00:25:29, Siggi Cherem (dart-lang) wrote:
> style nit: add spaces around =>

Done.

https://codereview.chromium.org/12310123/diff/1/pkg/unittest/test/unittest_te...
pkg/unittest/test/unittest_test.dart:270: } else if (testName == 'test returning
future using isolate (Timer)') {
On 2013/02/26 00:25:29, Siggi Cherem (dart-lang) wrote:
> nit: I'd just say '... future using Timer'?

Done.