Issue 12310117: Fix breakage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12310117: Fix breakage (Closed)

Created:
7 years, 9 months ago by Cutch

Modified:
7 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dart2js breakage from Simd landing Committed: https://code.google.com/p/dart/source/detail?r=19004

Patch Set 2 : Fix whitespace #

Patch Set 3 : Srdjan's review #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -0 lines)			Patch
	M	runtime/tests/vm/vm.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	sdk/lib/_internal/compiler/implementation/lib/scalarlist_patch.dart	View	1 2	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/12310117/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/12310117/diff/1/runtime/tests/vm/vm.status#newcode36 runtime/tests/vm/vm.status:36: dart/simd128float32_array_test: Skip # compilers not aware of byte ...

7 years, 9 months ago (2013-02-25 21:46:22 UTC) #3

Cutch

7 years, 9 months ago (2013-02-25 21:50:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r19004 (presubmit successful).