Issue 12310040: Fix broken use lists in branch instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12310040: Fix broken use lists in branch instructions. (Closed)

Created:
7 years, 10 months ago by Kevin Millikin (Google)

Modified:
7 years, 10 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix broken use lists in branch instructions. BranchInstr::ReplaceWith is used in two different places that have different expectations about the use lists of their argument. Split it into two separate functions. R=fschneider@google.com BUG=dart:8657 Committed: https://code.google.com/p/dart/source/detail?r=18826

Patch Set 1 #

Patch Set 2 : Remove debugging code. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -11 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		2 chunks	+7 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	2 chunks	+33 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

7 years, 10 months ago (2013-02-21 12:51:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r18826 (presubmit successful).

Expand Messages | Collapse Messages