Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 12308005: Fix static name resolution in mixing code (Closed)

Created:
7 years, 10 months ago by hausner
Modified:
7 years, 10 months ago
Reviewers:
iposva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix static name resolution in mixing code In mixin code, static names need to be looked up in the mixin class. OTOH, in patch classes, we need to resolve static names in the class into with the code is patched. I'm all for simplicity! TBR=iposva Committed: https://code.google.com/p/dart/source/detail?r=18710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M runtime/vm/parser.cc View 1 chunk +8 lines, -1 line 0 comments Download
M tests/language/mixin_extends_method_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 10 months ago (2013-02-19 17:57:15 UTC) #1
hausner
TBR
7 years, 10 months ago (2013-02-19 18:27:28 UTC) #2
Ivan Posva
7 years, 10 months ago (2013-02-19 19:04:29 UTC) #3
Message was sent while issue was closed.
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698