Issue 1230553003: Revert "appendHtml, when sanitizing, should create document fragment in the right context"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1230553003: Revert "appendHtml, when sanitizing, should create document fragment in the right context" (Closed)

Created:
5 years, 5 months ago by Alan Knight

Modified:
5 years, 5 months ago

Reviewers:
terry

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "appendHtml, when sanitizing, should create document fragment in the right context" This reverts commit 560f12bb21874824788e1f660ca07b8914c8cc4f. modified: sdk/lib/html/dart2js/html_dart2js.dart modified: sdk/lib/html/dartium/html_dartium.dart modified: tests/html/element_add_test.dart modified: tools/dom/templates/html/impl/impl_Element.darttemplate BUG= Committed: https://github.com/dart-lang/sdk/commit/1e8a275a2015dbb7bdf8fada5f15f46de5e9abca

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -16 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/element_add_test.dart	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Alan Knight

5 years, 5 months ago (2015-07-08 19:19:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1e8a275a2015dbb7bdf8fada5f15f46de5e9abca (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages